On Wed, Aug 01, 2012 at 04:01:49PM +0900, Simon Horman wrote:
> It seems that ofp_version suffices in all cases.
> 
> Signed-off-by: Simon Horman <ho...@verge.net.au>

When I changed uint8_t to enum ofp_version in the previous patch, this
caused a few patch rejects, which I resolved (but please do check my
work).

In addition, I removed a couple more references to ofperr_domain from
ofp-errors.h:

diff --git a/build-aux/extract-ofp-errors b/build-aux/extract-ofp-errors
index 1ec5ba4..e513b7f 100755
--- a/build-aux/extract-ofp-errors
+++ b/build-aux/extract-ofp-errors
@@ -343,7 +343,7 @@ static enum ofperr
 }"""
 
         print """
-const struct ofperr_domain %s = {
+static const struct ofperr_domain %s = {
     "%s",
     %d,
     %s_decode,
diff --git a/lib/ofp-errors.h b/lib/ofp-errors.h
index 85afef6..2f28a42 100644
--- a/lib/ofp-errors.h
+++ b/lib/ofp-errors.h
@@ -496,10 +496,6 @@ enum ofperr {
     OFPERR_OFPET_EXPERIMENTER,
 };
 
-extern const struct ofperr_domain ofperr_of10;
-extern const struct ofperr_domain ofperr_of11;
-extern const struct ofperr_domain ofperr_of12;
-
 const char *ofperr_domain_get_name(enum ofp_version);
 
 bool ofperr_is_valid(enum ofperr);

and queued this up for master.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to