On Thu, Aug 09, 2012 at 05:49:27PM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman <[email protected]>

This patch is really quite odd.  Before and after this patch, the
top-level function ofputil_decode_flow_stats_request() determines the
raw type and pulls off the OpenFlow header.  But after this patch, the
function ofputil_decode_ofpst_flow_request() does all that work over
again.  I think that you did cut-and-paste from
ofputil_decode_flow_stats_reply() into
ofputil_decode_ofpst_flow_request(), even though the situations are
different (a flow stats reply might have several flow stats
back-to-back, but a flow stats request has exactly one stats request).
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to