On Mon, Aug 13, 2012 at 4:02 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Wed, Aug 08, 2012 at 07:21:23PM -0700, Jesse Gross wrote:
>> At the end of the NetFlow unit tests we warp time to force any
>> remaining flows to expire and then immediately kill OVS and the
>> collector.  However, this creates a race where sometimes these
>> processes are killed before the last records are sent or collected.
>> It's possible to force OVS to go through the run loop one last time
>> before exiting but it's harder to enforce that the collector receives
>> the packet.  This simply avoids the problem by adding a 1 second delay
>> before killing the processes, which should be more than enough time.
>>
>> Signed-off-by: Jesse Gross <je...@nicira.com>
>
> Thanks, this looks good.  Sleeping in the unit tests isn't ideal but
> it's better than failing.

Thanks, I pushed this.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to