On Wed, Aug 22, 2012 at 01:23:44PM -0700, Ethan Jackson wrote:
> It's not entirely clear what problem the null interface type is
> trying to solve, nor how it could be of use to any controller.
> This patch deprecates it, and schedules its removal for February
> 2013. If there are concerns, please email [email protected].
>
> Signed-off-by: Ethan Jackson <[email protected]>
Looks good to me.
I might consider swapping the order of the "null" and non-"null" cases,
but I didn't apply this and look at the context, so maybe it looks
better as you have it:
> } else if (strcmp(type, "null")) {
> bridge_queue_if_cfg(br, cfg, port);
> + } else {
> + VLOG_WARN_ONCE("%s: The null interface type is deprecated
> and"
> + " may be removed in February 2013. Please
> email"
> + " [email protected] with concerns.",
> + cfg->name);
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
