Commit a699f614 (lib: Utilize smaps in the idl.) broke the other_config:stp-enable port setting in two ways. First, it changed the default if the setting was missing to disabled. Second, if the setting was present, it did the opposite of what the user configured.
Bug #13122. Reported-by: Paul Ingram <[email protected]> Signed-off-by: Ethan Jackson <[email protected]> --- vswitchd/bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 0225739..53bb7b9 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -885,7 +885,7 @@ port_configure_stp(const struct ofproto *ofproto, struct port *port, const char *config_str; struct iface *iface; - if (smap_get_bool(&port->cfg->other_config, "stp-enable", false)) { + if (!smap_get_bool(&port->cfg->other_config, "stp-enable", true)) { port_s->enable = false; return; } else { -- 1.7.11.4 _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
