On Fri, Aug 31, 2012 at 11:51:19AM +0900, Simon Horman wrote: > On Thu, Aug 30, 2012 at 11:32:06AM -0700, Ben Pfaff wrote: > > On Thu, Aug 30, 2012 at 10:40:23AM +0900, Simon Horman wrote: > > > From: Isaku Yamahata <[email protected]> > > > > > > Add necessary macros to ofp-util for OF12 support. > > > This is just a place holder. > > > > > > Signed-off-by: Isaku Yamahata <[email protected]> > > > Signed-off-by: Simon Horman <[email protected]> > > > > I think that the new NOT_REACHED() in parse_named_action() can actually > > be hit if the user attempts to use this action. I'd rather avoid adding > > that kind of breakage, even temporarily. I can see a few ways to avoid > > it. The most obvious ones are to leave OFPAT12_SET_FIELD commented out > > with the rest of the new actions in ofp-util.def or to give NULL as its > > name in ofp-util.def. > > That sounds reasonable to me. I have gone for the NULL name option > in the revised patch (v4) below.
I get: cc1: warnings being treated as errors ../lib/ofp-parse.c: In function ‘parse_named_action’: ../lib/ofp-parse.c:326: error: enumeration value ‘OFPUTIL_OFPAT12_SET_FIELD’ not handled in switch Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
