On Fri, Aug 31, 2012 at 9:55 AM, Ben Pfaff <b...@nicira.com> wrote: > On Fri, Aug 31, 2012 at 10:44:06PM +1200, Joe Stringer wrote: >> This patchset introduces matching support for sctp src,dst ports. I've >> tested the changes with both dpif-netdev and dpif-linux, using lksctp >> on kvm instances as the endpoints. Traffic flows normally, then by >> adding a rule to drop SCTP traffic on a particular port, I prevent the >> hosts communicating. Removing the rule allowed the endpoints to >> communicate again. > > Jesse, do you want to make a first pass on this series? (I see that you > already made one comment on one patch.) It seems to me that the series > is gated on the kernel changes making sense (I haven't read them), and > then the rest should fall in behind it. > > I'm happy to additionally or instead review whatever parts you like.
Simon and Kyle have been very patiently waiting for reviews on the tunneling stuff and I've been (repeatedly) promising them that I'll look at it, so I'm going to focus on that first. If you have some time before I'm done with that then you might want to go ahead and look at this first. I skimmed the kernel changes and while I noticed a few things, the structure seemed basically right. None of my comments should affect the userspace portions. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
