I see that Ben already reviewed and pushed, only saw a comment-typo and a message-typo that Ben seems to have seen. My only nit would be using some generic Error for the parameter checking (ValueError, or ovs-specific) instead of raising Exception. The register decorators / helper classes seem reasonable and clean, if a little overkill compared to a conditional in open(). Thanks!
-Reid On Mon, Oct 15, 2012 at 11:55 AM, Reid Price <r...@nicira.com> wrote: > > Sorry, was out of town on Sept 27th, this was still in my mail queue. I'll > look over this immediately. > > > On Mon, Oct 15, 2012 at 10:13 AM, Ben Pfaff <b...@nicira.com> wrote: >> >> The only blocker is that I was hoping for reviews from Reid. Since >> it's been a while and none has arrived, I'll review them myself. >> >> If by decorator you just mean @staticmethod, that's OK, we use those >> elsewhere. >> >> On Tue, Oct 16, 2012 at 01:37:42AM +0900, Isaku Yamahata wrote: >> > Ping? What's the blocker? >> > If the use of decorator is the issue, I'll rewrite it without decorator. >> > >> > On Thu, Sep 27, 2012 at 09:20:53AM -0700, Ben Pfaff wrote: >> > > On Thu, Sep 27, 2012 at 06:28:06PM +0900, Isaku Yamahata wrote: >> > > > This patch series add tcp socket support to python ovs binding in >> > > > addition >> > > > to unix socket. >> > > >> > > Reid, would you mind taking a look at this pair of patches? Your >> > > Python-fu is greater than mine. >> > > >> > > Thanks, >> > > >> > > Ben. >> > > _______________________________________________ >> > > dev mailing list >> > > dev@openvswitch.org >> > > http://openvswitch.org/mailman/listinfo/dev >> > > >> > >> > -- >> > yamahata > > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
