On Tue, Oct 16, 2012 at 08:02:44PM -0700, Ethan Jackson wrote:
> The new ovs-parse-backtrace utility makes the output of ovs-appctl
> backtrace more human readable by removing duplicate traces and
> converting addresses to function names.
> 
> Signed-off-by: Ethan Jackson <[email protected]>

Looks good.

My only suggestion is that, when the utility picks a default binary
because the user didn't specify one explicitly, the utility should print
the name of the binary that it is reading.  Otherwise, I expect that
someday someone (quite possibly me) will have mismatched
/usr/sbin/ovs-vswitchd and /usr/lib/debug/usr/sbin/ovs-vswitchd.debug
and end up confused.  It may still happen if we print the binary name,
but it might help, too.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to