On Thu, Oct 18, 2012 at 08:57:47AM -0700, Ben Pfaff wrote: > On Thu, Oct 18, 2012 at 07:02:04AM +0900, Isaku Yamahata wrote: > > action keyword dec_ttl is already used for NX dec_ttl. So dec_nw_ttl is > > introduced to disambiguate them. > > > > Signed-off-by: Isaku Yamahata <[email protected]> > > Thanks for the patch. > > I don't like the idea of having separate keywords "dec_ttl" and > "dec_nw_ttl" that really mean the same thing. So I changed the patch to > use "dec_ttl" for OF1.1+ also, and pushed it as follows:
The modified version looks good. The motivation for new keyword is as follows. Do you have any suggestion to address those? - ovs-ofctl <options to use OF11+> add-flow actions=dec_ttl always sends nx dec_ttl, not OF11 dec ttl. - Making ofpact_to_openflow11() to use OF11 dec ttl unconditionally doesn't work because dump-flow gets actions=of dec_ttl even when sending actions=nx dec_ttl. This might not be an issue, though. -- yamahata _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
