On Thu, Nov 1, 2012 at 1:26 PM, Pravin Shelar <pshe...@nicira.com> wrote: > > On Thu, Nov 1, 2012 at 1:09 PM, Ben Pfaff <b...@nicira.com> wrote: >> >> On Thu, Nov 01, 2012 at 12:47:47PM -0700, Pravin B Shelar wrote: >> > Following patch fixes `ovs-appctl ofproto/trace` command with >> > ipv4_tunnel key in flow. >> > >> > Bug #13785 >> > Signed-off-by: Pravin B Shelar <pshe...@nicira.com> >> >> Thank you! >> >> Will you please add a test to tests/odp.at? >> >> Please use "%"SCNi32 for flags instead of "%i", because tun_flags is a >> __u32 not an int. > > > Jesse mentioned that he has a patch for same and will send it.
I realized that the tests that I have are dependent on the rest of the infrastructure to actually read the tunnel flow information into userspace - otherwise you won't get the same thing out as is put in. I don't want put that code in yet and I'm not sure that it's worth adding a special test for something that's going to change almost immediately. I'll still post my patch since it has a few small improvements but it's basically the same as Pravin's at this point. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
