On Tue, Nov 20, 2012 at 05:59:12PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben and Jesse.
Please break the following across two lines, after the *:
> +const char *flow_tun_flag_to_string(uint32_t flags)
I think that the ds_put_format() calls inside the switch statement in
flow_tunnel_format() should have trailing commas:
> + switch (wc->masks.tunnel.tun_id) {
> + case 0:
> + return;
> + case CONSTANT_HTONLL(UINT64_MAX):
> + ds_put_format(s, "tun_id=%#"PRIx64, ntohll(tnl->tun_id));
> + break;
> + default:
> + ds_put_format(s, "tun_id=%#"PRIx64"/%#"PRIx64,
> + ntohll(tnl->tun_id),
> + ntohll(wc->masks.tunnel.tun_id));
> + break;
> + }
and that the ds_put_char here should be moved inside the "if" block:
> + if (wc->masks.tunnel.flags) {
> + format_flags(s, flow_tun_flag_to_string, tnl->flags, '|');
> + }
> + ds_put_char(s, ',');
> +}
That's all I see.
Thank you!
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
