On Wed, Nov 21, 2012 at 2:54 PM, Pravin B Shelar <[email protected]> wrote: > +static void > +format_flow_tunnel(struct ds *s, const struct match *match) > +{ > + const struct flow_wildcards *wc = &match->wc; > + const struct flow_tnl *tnl = &match->flow.tunnel; > + > + switch (wc->masks.tunnel.tun_id) { > + case 0: > + break; > + case CONSTANT_HTONLL(UINT64_MAX): > + ds_put_format(s, "tun_id=%#"PRIx64",", ntohll(tnl->tun_id)); > + break; > + default: > + ds_put_format(s, "tun_id=%#"PRIx64"/%#"PRIx64",", > + ntohll(tnl->tun_id), > + ntohll(wc->masks.tunnel.tun_id)); > + break; > + } > + format_ip_netmask(s, "tun_src", tnl->ip_src, wc->masks.tunnel.ip_src); > + format_ip_netmask(s, "tun_dst", tnl->ip_dst, wc->masks.tunnel.ip_dst); > + > + if (wc->masks.tunnel.ip_tos) { > + ds_put_format(s, "tun_tos=%"PRIu8",", tnl->ip_tos);
This was actually the part that I was more concerned about as far as hex vs. decimal. Can you print out the ToS in hex? Otherwise, looks good to me. I also don't need to look at it again. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
