On Thu, Nov 22, 2012 at 09:02:54AM +0200, Ansis Atteka wrote: > My previous dcb66daea433cd93593e517c3fac3c898f2c9f70 commit broke > 32-bit builds. This patch assures that size of struct flow is equal > on both 32-bit and 64-bit architectures so that build asserts do not > fire anymore. > > Signed-off-by: Ansis Atteka <[email protected]>
We normally put padding at the end of a structure, not in the middle. Some places in the code must zero the padding if there is any. You can refer to Justin's commit ddbfda846297 (Use ODP ports in dpif layer and below.) as a reference: search for 'zeros' in that patch to see where to zero the padding. We usually call this member 'zeros' instead of 'reserved'. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
