On Thu, Nov 29, 2012 at 05:12:44PM +0900, Simon Horman wrote: > On Thu, Nov 29, 2012 at 04:28:11PM +0900, Simon Horman wrote: > > On Wed, Nov 28, 2012 at 11:06:47PM -0800, Ben Pfaff wrote: > > > Simon, here's a revision of the remaining patches in your most > > > recent posting of your OpenFlow 1.2 series. Will you please > > > look it over, especially the patches that I added? If you think > > > it's good, then I'm ready to push it to master. > > > > > > I think these are the only outstanding patches that you're waiting > > > on me to review. (Jesse needs to look at the MPLS patches.) Let > > > me know if I missed any. > > > > Thanks, I'll look over it and get back to you ASAP. > > Thanks, these all look good to me and seem to work too.
Thanks for the reviews. I applied your acks and changelog revisions and pushed this to master. > One outstanding problem I have with this series (and my versions > of it too) which I only noticed recently is that ovs-vswitchd > seems to need to be restarted in order for changes to the protocols > field to take affect. > > # ovs-vsctl set bridge br0 protocols='[OpenFlow10, OpenFlow12, OpenFlow13]' > # ovs-ofctl --protocols OpenFlow12 dump-flows br0 > 2012-11-29T08:05:16Z|00001|vconn|WARN|unix:/var/run/openvswitch/br0.mgmt: > version negotiation failed (we support version 0x03, peer supports version > 0x01) > ovs-ofctl: br0: failed to connect to socket (Broken pipe) > # /etc/init.d/openvswitch-switch restart > # ovs-ofctl --protocols OpenFlow12 dump-flows br0 > OFPST_FLOW reply (OF1.2) (xid=0x2): > cookie=0x0, duration=2.04s, table=0, n_packets=0, n_bytes=0, priority=0 > actions=NORMAL > > > I plan to hunt this down, but as we are here, do you have any advice > on where this problem may lie? I'd guess that the problem is somewhere in propagating the configuration from bridge down to the vconn. (Maybe that is so obvious that it isn't useful information.) _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
