On Sat, Dec 1, 2012 at 4:00 PM, Ben Pfaff <[email protected]> wrote: > On Sat, Dec 01, 2012 at 03:54:58PM -0800, Justin Pettit wrote: > > On Sat, Dec 1, 2012 at 11:25 AM, Ben Pfaff <[email protected]> wrote: > > > > > Ideally we'd add one or two usages to tests/ovs-vsctl.at. > > > > Okay. How about the following incremental? > > Looks good, thanks. > > > > One could write this: > > > if ((br->parent && fake) || (!br->parent && real)) { > > > as: > > > if (br->parent ? fake : real) { > > > Personally I think that's more straightforward, but you may not agree. > > > Certainly, I understand both forms. > > > > > > > Yeah, I think that's cleaner. I went ahead and changed it to that. > > Thanks. >
Thanks for the weekend reviews. I've pushed this master and "branch-1.9". --Justin
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
