On Wed, Dec 05, 2012 at 05:03:40PM -0800, Ben Pfaff wrote: > On Thu, Dec 06, 2012 at 09:49:56AM +0900, Simon Horman wrote: > > On Tue, Dec 04, 2012 at 05:51:04PM -0800, Ben Pfaff wrote: > > > rconn_create() was substituting OFPUTIL_DEFAULT_VERSIONS if an > > > allowed_versions of 0 was passed in. At the same time, > > > connmgr_set_controllers() compared the adjusted value of allowed_versions > > > against the original value, saw that they were different, and concluded > > > that it should kill off and recreate the rconn with the "corrected" > > > allowed_versions. > > > > > > This commit fixes the problem by no longer adjusting allowed_versions. > > > There is no need, because it is only used in contexts where the original > > > version is OK. > > > > > > This problem was introduced by commit 90ef0206ea8f5a39 (connmgr: > > > Reinitialise controllers if protocols changes). > > > > > > Bug #14126. > > > CC: Simon Horman <[email protected]> > > > Reported-by: Natasha Gude <[email protected]> > > > Signed-off-by: Ben Pfaff <[email protected]> > > > > Acked-by: Simon Horman <[email protected]> > > Thanks for looking it over. I pushed this last night.
Thanks for fixing the problem. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
