On Dec 18, 2012, at 14:51 , ext SUGYO Kazushi wrote:
> Signed-off-by: SUGYO Kazushi <sugyo....@gmail.com>
> 
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index f95d6ef..cbabae9 100644
> --- a/ofproto/ofproto.c
> +++ b/ofproto/ofproto.c
> @@ -2245,8 +2245,11 @@ handle_features_request(struct ofconn *ofconn, const 
> stru
>     features.auxiliary_id = 0;
>     b = ofputil_encode_switch_features(&features, ofconn_get_protocol(ofconn),
>                                        oh->xid);
> -    HMAP_FOR_EACH (port, hmap_node, &ofproto->ports) {
> -        ofputil_put_switch_features_port(&port->pp, b);
> +    /* features reply of openflow13 does not have ports */
> +    if (oh->version < OFP13_VERSION

Should have ") {" at the end of line.

> +        HMAP_FOR_EACH (port, hmap_node, &ofproto->ports) {
> +            ofputil_put_switch_features_port(&port->pp, b);
> +        }
>     }
> 
>     ofconn_send_reply(ofconn, b);
> --


Otherwise looks right.

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to