Looks good.

--Justin


On Dec 18, 2012, at 1:51 PM, Ben Pfaff <b...@nicira.com> wrote:

> 'devname' needs to be destroyed whether it's the datapath device or not.
> 
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> ofproto/ofproto-dpif.c |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index b78d6cf..6ce9a07 100644
> --- a/ofproto/ofproto-dpif.c
> +++ b/ofproto/ofproto-dpif.c
> @@ -836,7 +836,7 @@ type_run(const char *type)
> 
>         /* Don't report on the datapath's device. */
>         if (!strcmp(devname, dpif_base_name(backer->dpif))) {
> -            continue;
> +            goto next;
>         }
> 
>         ofproto = lookup_ofproto_dpif_by_port_name(devname);
> @@ -857,6 +857,7 @@ type_run(const char *type)
>         }
>         dpif_port_destroy(&port);
> 
> +    next:
>         free(devname);
>     }
> 
> -- 
> 1.7.2.5
> 
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev

_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to