On Dec 28, 2012, at 19:22 , ext Ben Pfaff wrote: > On Fri, Dec 28, 2012 at 06:28:49PM +0200, Jarno Rajahalme wrote: >> >> Signed-off-by: Jarno Rajahalme <jarno.rajaha...@nsn.com> >> --- >> >> v3 makes ofputil_decode_role_request() handle also replies and >> check the validity of the role. Now also used in ofp-print.c. > > Thanks! I'm going to apply this in a minute, with a few changes: > > In ofp_print_role_message(), print the error if there is one. > > Rename ofputil_decode_role_request() to ofputil_decode_role_message() > since it handles requests and replies now. > > Add comment about EXT-272. > > The incremental versus your patch is: >
Looks all good to me, thanks! Jarno _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
