As requested off list, I've filled out the commit message a bit. I'll
merge soon.
in-band: Use "internal" netdev type for local ports.
A bridge's local port always has type "internal", so opening it
with type "system" can't be correct. This was causing upgrade
problems. Specifically, in certain bridge topologies, if there was
a manager set force-reload-kmod would fail. This is because the
local port netdev would open in the in-band code with type
"system", confusing the more important netdev_open() in
iface_create().
Bug #15067.
Signed-off-by: Ethan Jackson <[email protected]>
On Fri, Feb 22, 2013 at 6:53 AM, Ben Pfaff <[email protected]> wrote:
> Looks good, thank you.
> On Feb 21, 2013 9:18 PM, "Ethan Jackson" <[email protected]> wrote:
>
>> A bridge's local port always has type "internal", so opening it
>> with type "system" can't be correct. This was causing problems
>> with force-reload-kmod in some circumstances.
>>
>> Bug #15067.
>> Signed-off-by: Ethan Jackson <[email protected]>
>> ---
>> ofproto/in-band.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ofproto/in-band.c b/ofproto/in-band.c
>> index 3b98005..1a08fcc 100644
>> --- a/ofproto/in-band.c
>> +++ b/ofproto/in-band.c
>> @@ -464,7 +464,7 @@ in_band_create(struct ofproto *ofproto, const char
>> *local_name,
>> int error;
>>
>> *in_bandp = NULL;
>> - error = netdev_open(local_name, "system", &local_netdev);
>> + error = netdev_open(local_name, "internal", &local_netdev);
>> if (error) {
>> VLOG_ERR("failed to initialize in-band control: cannot open "
>> "datapath local port %s (%s)", local_name,
>> strerror(error));
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> dev mailing list
>> [email protected]
>> http://openvswitch.org/mailman/listinfo/dev
>>
>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
