Thanks for the comments. I will post the reworked patch based on the feedbacks to this thread soon.
On Wed, Feb 27, 2013 at 8:44 PM, Ben Pfaff <[email protected]> wrote: > On Wed, Feb 27, 2013 at 05:12:16PM -0800, Ethan Jackson wrote: > > +static union mf_value* > > > +nx_stack_pop(struct ofpbuf* stack) > > > +{ > > > + union mf_value* v = NULL; > > > + if (stack->size) { > > > + stack -> size -= sizeof *v; > > > + v = (union mf_value*)((char*)stack->data + stack->size); > > > + } > > > + > > > + return v; > > > +} > > > + > > > > > > > Any reason we can't just use ofpbuf_try_pull() instead? > > I think that would make it a queue instead of a stack. >
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
