During rpm install got Warning i think it might be critical:

yum localinstall --nogpgcheck
~/rpmbuild/RPMS/x86_64/kmod-openvswitch-1.9.0-1.el6.x86_64.rpm

WARNING:
/lib/modules/2.6.32-358.el6.x86_64/weak-updates/openvswitch/brcompat.ko
needs unknown symbol ovs_dp_ioctl_hook
  Verifying  : kmod-openvswitch-1.9.0-1.el6.x86_64

                   1/1

Installed:
  kmod-openvswitch.x86_64 0:1.9.0-1.el6




On Wed, Mar 13, 2013 at 1:19 AM, Jesse Gross <[email protected]> wrote:

> Centos 6.4 backported a number of additional functions so our existing
> versions started causing conflicts.
>
> Reported-by: Denis Iskandarov <[email protected]>
> Signed-off-by: Jesse Gross <[email protected]>
> ---
> v2: Check for eth_hw_addr_random and vlan_set_encap_proto as well.
> ---
>  acinclude.m4                                      |    5 +++++
>  datapath/linux/compat/include/linux/etherdevice.h |    2 ++
>  datapath/linux/compat/include/linux/if_vlan.h     |    2 +-
>  datapath/linux/compat/include/linux/skbuff.h      |    2 +-
>  4 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/acinclude.m4 b/acinclude.m4
> index 02dc952..f0610c9 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -215,6 +215,10 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [
>
>    OVS_GREP_IFELSE([$KSRC/include/linux/err.h], [ERR_CAST])
>
> +  OVS_GREP_IFELSE([$KSRC/include/linux/etherdevice.h],
> [eth_hw_addr_random])
> +
> +  OVS_GREP_IFELSE([$KSRC/include/linux/if_vlan.h], [vlan_set_encap_proto])
> +
>    OVS_GREP_IFELSE([$KSRC/include/linux/in.h], [ipv4_is_multicast])
>
>    OVS_GREP_IFELSE([$KSRC/include/linux/netdevice.h], [dev_disable_lro])
> @@ -249,6 +253,7 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [
>                    [OVS_DEFINE([HAVE_SKB_WARN_LRO])])
>    OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [consume_skb])
>    OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [skb_frag_page])
> +  OVS_GREP_IFELSE([$KSRC/include/linux/skbuff.h], [skb_reset_mac_len])
>
>    OVS_GREP_IFELSE([$KSRC/include/linux/string.h], [kmemdup], [],
>                    [OVS_GREP_IFELSE([$KSRC/include/linux/slab.h],
> [kmemdup])])
> diff --git a/datapath/linux/compat/include/linux/etherdevice.h
> b/datapath/linux/compat/include/linux/etherdevice.h
> index b2c3353..eb7123e 100644
> --- a/datapath/linux/compat/include/linux/etherdevice.h
> +++ b/datapath/linux/compat/include/linux/etherdevice.h
> @@ -4,6 +4,7 @@
>  #include <linux/version.h>
>  #include_next <linux/etherdevice.h>
>
> +#ifndef HAVE_ETH_HW_ADDR_RANDOM
>  #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,36)
>  static inline void eth_hw_addr_random(struct net_device *dev)
>  {
> @@ -15,6 +16,7 @@ static inline void eth_hw_addr_random(struct net_device
> *dev)
>         dev_hw_addr_random(dev, dev->dev_addr);
>  }
>  #endif
> +#endif
>
>  #if LINUX_VERSION_CODE < KERNEL_VERSION(3,6,0)
>  #define eth_mac_addr rpl_eth_mac_addr
> diff --git a/datapath/linux/compat/include/linux/if_vlan.h
> b/datapath/linux/compat/include/linux/if_vlan.h
> index dc4b15e..b8b1961 100644
> --- a/datapath/linux/compat/include/linux/if_vlan.h
> +++ b/datapath/linux/compat/include/linux/if_vlan.h
> @@ -55,7 +55,7 @@ static inline struct sk_buff *__vlan_put_tag(struct
> sk_buff *skb, u16 vlan_tci)
>  #define VLAN_TAG_PRESENT       VLAN_CFI_MASK
>  #endif
>
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(3,3,0)
> +#ifndef HAVE_VLAN_SET_ENCAP_PROTO
>  static inline void vlan_set_encap_proto(struct sk_buff *skb, struct
> vlan_hdr *vhdr)
>  {
>         __be16 proto;
> diff --git a/datapath/linux/compat/include/linux/skbuff.h
> b/datapath/linux/compat/include/linux/skbuff.h
> index 7fbe9d8..d485b39 100644
> --- a/datapath/linux/compat/include/linux/skbuff.h
> +++ b/datapath/linux/compat/include/linux/skbuff.h
> @@ -245,7 +245,7 @@ static inline struct page *skb_frag_page(const
> skb_frag_t *frag)
>  }
>  #endif
>
> -#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,40)
> +#ifndef HAVE_SKB_RESET_MAC_LEN
>  static inline void skb_reset_mac_len(struct sk_buff *skb)
>  {
>         skb->mac_len = skb->network_header - skb->mac_header;
> --
> 1.7.10.4
>
>
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev

Reply via email to