On Wed, Mar 13, 2013 at 03:38:01PM -0700, Gurucharan Shetty wrote: > We use ovs-ctl from startup scripts to start, stop, restart, > force-reload-kmod OVS daemons. ovs-ctl gives quite a descriptive > o/p while running the above commands. But the o/p goes to stdout. > Sometimes, this output is quite useful to debug issues. > > With this patch, we store the o/p of ovs-ctl when called from > startup scripts in /var/log/openvswitch/ovs-ctl.log > > Signed-off-by: Gurucharan Shetty <[email protected]>
This looks good. I think that we could move the ovs_ctl function into ovs-lib, since it is now used in all our startup scripts and defined identically in each place. At that point, it should probably use $datadir and $logdir instead of hard-coding them. It would be nice if this didn't combine stdout and stderr into a single stream for the ultimate caller. I looked at some samples that avoid that on stackoverflow, but they are bash-specific. I think that the advantages of logging outweigh this minor issue, so let's ignore it for now at least. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
