On Wed, Mar 27, 2013 at 11:02:21PM -0700, Neil Mckee wrote:
> This patch adds an sFlow test to the test suite (in branch 1.10).  To
> make that work properly I added netdev_dummy_get_ifindex() so that a
> dummy netdev can return a dummy ifindex when asked.  Is there anywhere
> in OVS that assumes that a netdev_dummy cannot make up a dummy
> ifindex?  If so, I guess this behavior could be off by default and
> turned on just for this test.

I think this behavior is fine.

Thanks a lot, it will be really great to have a test for sflow also.

(I'll do a formal review later.)
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to