On Mon, Apr 08, 2013 at 10:51:44AM -0700, Justin Pettit wrote:
> @@ -2274,7 +2274,8 @@ bridge_run(void)
>              struct bridge *br, *next_br;
>  
>              VLOG_ERR_RL(&rl, "another ovs-vswitchd process is running, "
> -                        "disabling this process until it goes away");
> +                        "disabling this process (%d) until it goes away",
> +                        getpid());

pid_t isn't necessarily compatible with int.  It might be any integer
type.  The cautious thing to do is to cast it to some specific integer
type to use it with a format string.  I usually cast to "long int" and
use %ld.

I might say (pid %ld) instead of just (%d) to make it really clear
what the number is.

Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to