On Wed, May 01, 2013 at 09:54:03AM -0700, Ben Pfaff wrote: > On Wed, May 01, 2013 at 05:06:02PM +0900, Simon Horman wrote: > > The ethertype should always be updated on mpls_pop > > as there may be a transition between MPLS unicast (0x8847) and > > MPLS multicast (0x8848). > > > > Signed-off-by: Simon Horman <[email protected]> > > The comment on pop_mpls() needs an update. > > EXT-194 in the OpenFlow extensibility JIRA bug tracker says that this > is the correct behavior. Will you cite that in a comment and the > commit log?
Sure, can you let me know where I can view EXT-194. > Also, this commit would make the documentation in ovs-ofctl.8.in > wrong: > > .IP \fBpop_mpls\fR:\fIethertype\fR > Strips the outermost MPLS label stack entry. If the MPLS label > stripped was the only one, changes the ethertype of a packet to > \fIethertype\fR, which should not ordinarily be an MPLS Ethertype. Thanks, I will fix that. > Also, the action parser in ofp-actions.def rejects any pop_mpls action > with an MPLS ethertype attached, in two places. We should fix that. Thanks, I am working on a fix for that. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
