On Wed, May 01, 2013 at 09:42:18PM -0700, Jesse Gross wrote: > On Wed, May 1, 2013 at 1:11 AM, Simon Horman <ho...@verge.net.au> wrote: > > learn_parse() needs to know the current ethertype, including any > > updates made by MPLS push and pop actions in order to determine if > > access to fields is valid or not. > > > > Changes made to ethertype my VLAN push and pop actions are excluded > > from this logic as they do not effect the behaviour of learn_parse. > > > > Signed-off-by: Simon Horman <ho...@verge.net.au> > > It seems like it may be better to just fully separate out parsing from > validation here like is done with the other actions and avoid the > issue altogether.
Ok, that makes sense. I believe that validation occurs for learn_actions anyway. So it is probably sufficient to just remove the checks from learn_parse(). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
