On Wed, May 08, 2013 at 10:50:14AM +0900, Simon Horman wrote: > Add a call to ofpacts_check() in parse_ofp_str() to check pre-requisites. > This is in preparation for removing special-case pre-requisite checking > of learn actions which is useful for the test-suite. > > This patch also fixes two tests which this change revealed to be incorrect. > > 1. Open Flow 1.0 learn action which sets NXM_NX_IPV6_SRC > without any pre-requisites > > This is not valid because there should be an IPv6 pre-requisite. > > This portion of the test has been removed as IPv6 pre-requisites are > only valid when using OXM or NXM, however the test appears > to be a (non-NXM) Open Flow 1.0 test. > > It has been replaced with a similar test of a learn action > that sets the IPv4 source address. > > 2. Open Flow 1.2 learn action which sets NXM_NX_IPV6_SRC > without any pre-requisites. > > This is not valid because there should be an IPv6 pre-requisite. > > This test has been corrected by adding IPv6 as a pre-requisite, > which is valid for Open Flow 1.2 as it uses OXM. > > Use of ofpacts_check() in parse_ofp_str() suggested by Ben Pfaff. > > Cc: Ben Pfaff <b...@nicira.com> > Signed-off-by: Simon Horman <ho...@verge.net.au>
I found the commit message confusing at first because it talks about "learn" actions but no "learn" actions appear in the tests that it modifies. I think this is just a bug in the commit message, so I modified it. I've queued this up to apply it. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
