I think you're right on both points, I've folded the changes in and will merge both patches shortly.
Thanks, Ethan On Thu, May 9, 2013 at 10:19 AM, Ben Pfaff <[email protected]> wrote: > On Wed, May 08, 2013 at 03:36:56PM -0700, Ethan Jackson wrote: >> Before this patch, send_packet() manually constructed the required >> datapath output actions. This worked fine when these actions were >> simple, however as outputting to tunnels and patch ports became >> more complex, this required quite a bit of complex duplicated code. >> This patch solves the problem by running through the standard >> xlate_actions() code path instead. >> >> Signed-off-by: Ethan Jackson <[email protected]> > > I am not sure that may_learn should be set to false. If the packet is > output to a patch port, which then goes through to a flow table that > does MAC learning, then I am not sure why we would not want that to > take place. > > One could write &output.ofpact here instead of using a cast: >> + xlate_actions(&ctx, (struct ofpact *) &output, sizeof output, >> + &odp_actions); > > Otherwise, looks good. > > Thanks, > > Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
