Super! Thank you very much for fixing it so quickly!! I'll try it out when I have some time.
Kind regards, Tim 2013/5/9 Ethan Jackson <[email protected]> > Thanks for the review, I'll add Tmusic and merge this shortly. > > Ethan > > On Thu, May 9, 2013 at 10:03 AM, Ben Pfaff <[email protected]> wrote: > > On Thu, May 02, 2013 at 04:08:06PM -0700, Ethan Jackson wrote: > >> Before this patch, stats for 'facet->rule' were handled differently > >> than stats which 'facet' resubmitted into. The former were > >> maintained in 'facet' until it was destroyed, while the latter were > >> pushed regularly in facet_push_stats(). > >> > >> This inconsistent behavior was not only confusing, it was often > >> incorrect. In some circumstances, if a facet changed rules, it > >> could carry the statistics from the entirety of its lifetime from > >> the old rule to the new one. This patch remedies the issue by > >> handling all rule stats in facet_push_stats(). > >> > >> Signed-off-by: Ethan Jackson <[email protected]> > > > > I think this fixes the bug reported earlier by Tmusic (CCed). If so, > > can you credit him (her?) with a Reported-by? > > > > Looks good to me, thanks. >
_______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
