Looks good to me. Want to ask what is the tradeoff between using "const
struct netdev" and "struct netdev" as input argument.
Thanks,
On Tue, May 21, 2013 at 3:42 PM, Ben Pfaff <b...@nicira.com> wrote:
> I suspect that this makes it easier to make sure that a netdev stays open
> as long as needed in some cases where a module needs access to a netdev
> opened by some higher-level module.
>
> CC: Ethan Jackson <et...@nicira.com>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
> lib/netdev.c | 11 +++++++++++
> lib/netdev.h | 1 +
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/lib/netdev.c b/lib/netdev.c
> index 5c2e9f5..5aae01c 100644
> --- a/lib/netdev.c
> +++ b/lib/netdev.c
> @@ -277,6 +277,17 @@ netdev_open(const char *name, const char *type,
> struct netdev **netdevp)
> return 0;
> }
>
> +/* Returns a reference to 'netdev_' for the caller to own. */
> +struct netdev *
> +netdev_ref(const struct netdev *netdev_)
> +{
> + struct netdev *netdev = CONST_CAST(struct netdev *, netdev_);
> +
> + ovs_assert(netdev->ref_cnt > 0);
> + netdev->ref_cnt++;
> + return netdev;
> +}
> +
> /* Reconfigures the device 'netdev' with 'args'. 'args' may be empty
> * or NULL if none are needed. */
> int
> diff --git a/lib/netdev.h b/lib/netdev.h
> index c7f3c1d..b1cc319 100644
> --- a/lib/netdev.h
> +++ b/lib/netdev.h
> @@ -110,6 +110,7 @@ bool netdev_is_reserved_name(const char *name);
>
> /* Open and close. */
> int netdev_open(const char *name, const char *type, struct netdev **);
> +struct netdev *netdev_ref(const struct netdev *);
> void netdev_close(struct netdev *);
>
> void netdev_parse_name(const char *netdev_name, char **name, char **type);
> --
> 1.7.2.5
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
