On Tue, Jul 30, 2013 at 07:49:12PM -0700, Andy Zhou wrote: > Handling of missing attributes in netlink can be tricky and turns out > to be error prone. The value (savings in netlink bandwidth) does not > seem to be significant enough to justify allowing them. This patch > series make both kernel and userspace always export priority and > skb_mark attribute. There will be follow on patches in the > direction of making all attributes explicit. > > Signed-off-by: Andy Zhou <az...@nicira.com>
I came across the skb_mark portion of this problem while re-basing the recirculation patches and I have that portion of your patch included in "Add packet recirculation" since v14. So for that portion of the patch: Acked-by: Simon Horman <ho...@verge.net.au> > --- > datapath/flow.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/datapath/flow.c b/datapath/flow.c > index 3acc743..62fdf85 100644 > --- a/datapath/flow.c > +++ b/datapath/flow.c > @@ -1694,8 +1694,7 @@ int ovs_flow_to_nlattrs(const struct sw_flow_key *swkey, > struct ovs_key_ethernet *eth_key; > struct nlattr *nla, *encap; > > - if (output->phy.priority && > - nla_put_u32(skb, OVS_KEY_ATTR_PRIORITY, output->phy.priority)) > + if (nla_put_u32(skb, OVS_KEY_ATTR_PRIORITY, output->phy.priority)) > goto nla_put_failure; > > if (swkey->tun_key.ipv4_dst && > @@ -1715,8 +1714,7 @@ int ovs_flow_to_nlattrs(const struct sw_flow_key *swkey, > goto nla_put_failure; > } > > - if (output->phy.skb_mark && > - nla_put_u32(skb, OVS_KEY_ATTR_SKB_MARK, output->phy.skb_mark)) > + if (nla_put_u32(skb, OVS_KEY_ATTR_SKB_MARK, output->phy.skb_mark)) > goto nla_put_failure; > > nla = nla_reserve(skb, OVS_KEY_ATTR_ETHERNET, sizeof(*eth_key)); > -- > 1.7.9.5 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
