Thanks for looking them over. I applied the ones that weren't BSD-specific. I'll give Ed a few more days to look over the rest, if he wants, since I just posted this series yesterday.
On Fri, Aug 02, 2013 at 10:16:31AM -0700, Alex Wang wrote: > Patches 01/27 - 10/27 all look good. Thanks, > > Alex Wang, > > > On Thu, Aug 1, 2013 at 2:29 PM, Ben Pfaff <[email protected]> wrote: > > > Signed-off-by: Ben Pfaff <[email protected]> > > --- > > lib/netdev-linux.c | 3 +-- > > lib/netdev.c | 6 ++---- > > 2 files changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c > > index 29d8ad9..cc86ec6 100644 > > --- a/lib/netdev-linux.c > > +++ b/lib/netdev-linux.c > > @@ -1424,8 +1424,7 @@ netdev_linux_get_stats(const struct netdev *netdev_, > > /* Retrieves current device stats for 'netdev-tap' netdev or > > * netdev-internal. */ > > static int > > -netdev_tap_get_stats(const struct netdev *netdev_, > > - struct netdev_stats *stats) > > +netdev_tap_get_stats(const struct netdev *netdev_, struct netdev_stats > > *stats) > > { > > struct netdev_linux *netdev = netdev_linux_cast(netdev_); > > struct netdev_stats dev_stats; > > diff --git a/lib/netdev.c b/lib/netdev.c > > index 6e2a92f..0079dc2 100644 > > --- a/lib/netdev.c > > +++ b/lib/netdev.c > > @@ -926,8 +926,7 @@ netdev_arp_lookup(const struct netdev *netdev, > > ovs_be32 ip, uint8_t mac[ETH_ADDR_LEN]) > > { > > int error = (netdev->netdev_class->arp_lookup > > - ? netdev->netdev_class->arp_lookup(netdev, > > - ip, mac) > > + ? netdev->netdev_class->arp_lookup(netdev, ip, mac) > > : EOPNOTSUPP); > > if (error) { > > memset(mac, 0, ETH_ADDR_LEN); > > @@ -952,8 +951,7 @@ netdev_get_carrier(const struct netdev *netdev) > > return true; > > } > > > > - error = netdev->netdev_class->get_carrier(netdev, > > - &carrier); > > + error = netdev->netdev_class->get_carrier(netdev, &carrier); > > if (error) { > > VLOG_DBG("%s: failed to get network device carrier status, > > assuming " > > "down: %s", netdev_get_name(netdev), > > ovs_strerror(error)); > > -- > > 1.7.10.4 > > > > _______________________________________________ > > dev mailing list > > [email protected] > > http://openvswitch.org/mailman/listinfo/dev > > _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
