> I am not sure whether the new call to bond_entry_reset() in
> bond_slave_register() is really necessary because tags were removed
> (bond_entry_reset() doesn't cause revalidation, for example), or whether
> it is a bug fix or, arguably, a refinement of existing behavior to
> ensure that all traffic is redistributed across all the slaves. If it's
> the latter, then it deserves a commit of its own to call out the
> improvement.
>
> Same for the new call to bond_entry_reset() in bond_slave_unregister(),
> except that there we can also delete the later code:
> if (bond->hash) {
> struct bond_entry *e;
> for (e = bond->hash; e <= &bond->hash[BOND_MASK]; e++) {
> if (e->slave == slave) {
> e->slave = NULL;
> }
> }
> }
> because bond_entry_reset() just cleared all the slaves to NULL.
I just added these calls to be consistent with the old code which
called bond_entry_reset() whenever bond_revalidate was set. I think
they're superfluous so I've decided to remove them from the patch.
> Acked-by: Ben Pfaff <[email protected]>
Thanks, I'll merge shortly.
Ethan
X-CudaMail-Whitelist-To: [email protected]
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
