Thanks.
On Sat, Aug 3, 2013 at 2:20 PM, Ben Pfaff <b...@nicira.com> wrote:
> On Sat, Aug 03, 2013 at 12:23:14PM -0700, Andy Zhou wrote:
> > When verbose mode tuned on, all dp flow fields described by the netlink
> > attributes are displayed, including fully wildcarded attributes.
> > Otherwise, the fully wildcarded attributes are omitted for brevity.
> >
> > Added -m option to "ovs-dpctl dump-flows" to enable verbose mode. It is
> > off by default.
> >
> > Signed-off-by: Andy Zhou <az...@nicira.com>
>
> I added documentation, as follows, and applied this.
>
> diff --git a/NEWS b/NEWS
> index c0a3ecb..6f5d13a 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -45,6 +45,7 @@ v1.11.0 - xx xxx xxxx
> in_port to some unused value, such as OFPP_NONE.)
> - ovs-dpctl:
> * New debugging commands "add-flow", "mod-flow", "del-flow".
> + * "dump-flows" now has a -m option to increase output verbosity.
> - In dpif-based bridges, cache action translations, which can improve
> flow set up performance by 80% with a complicated flow table.
> - New syslog format, prefixed with "ovs|", to be easier to filter.
> diff --git a/utilities/ovs-dpctl.8.in b/utilities/ovs-dpctl.8.in
> index 2b0036c..5c01570 100644
> --- a/utilities/ovs-dpctl.8.in
> +++ b/utilities/ovs-dpctl.8.in
> @@ -118,9 +118,11 @@ exactly one datapath exists, in which case that
> datapath is the
> default. When multiple datapaths exist, then a datapath name is
> required.
> .
> -.IP "\fBdump\-flows\fR [\fIdp\fR]"
> -Prints to the console all flow entries in datapath \fIdp\fR's
> -flow table.
> +.IP "[\fB\-m \fR| \fB\-\-more\fR] \fBdump\-flows\fR [\fIdp\fR]"
> +Prints to the console all flow entries in datapath \fIdp\fR's flow
> +table. Without \fB\-m\fR or \fB\-\-more\fR, output omits match fields
> +that a flow wildcards entirely; with \fB\-m\fR or \fB\-\-more\fR,
> +output includes all wildcarded fields.
> .
> .IP "\fBadd\-flow\fR [\fIdp\fR] \fIflow actions\fR"
> .IQ "[\fB\-\-clear\fR] [\fB\-\-may-create\fR] [\fB\-s\fR |
> \fB\-\-statistics\fR] \fBmod\-flow\fR [\fIdp\fR] \fIflow actions\fR"
> @@ -159,6 +161,10 @@ Deletes all flow entries from datapath \fIdp\fR's
> flow table.
> Causes the \fBshow\fR command to print packet and byte counters for
> each port within the datapaths that it shows.
> .
> +.IP "\fB\-m\fR"
> +.IQ "\fB\-\-more\fR"
> +Increases the verbosity of \fBdump\-flows\fR output.
> +.
> .IP "\fB\-t\fR"
> .IQ "\fB\-\-timeout=\fIsecs\fR"
> Limits \fBovs\-dpctl\fR runtime to approximately \fIsecs\fR seconds. If
> diff --git a/utilities/ovs-dpctl.c b/utilities/ovs-dpctl.c
> index 42cb205..0516d1b 100644
> --- a/utilities/ovs-dpctl.c
> +++ b/utilities/ovs-dpctl.c
> @@ -182,6 +182,8 @@ usage(void)
> vlog_usage();
> printf("\nOptions for show and mod-flow:\n"
> " -s, --statistics print statistics for port or
> flow\n"
> + "\nOptions for dump-flows:\n"
> + " -m, --more increase verbosity of output\n"
> "\nOptions for mod-flow:\n"
> " --may-create create flow if it doesn't
> exist\n"
> " --clear reset existing stats to zero\n"
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
