On Fri, Aug 23, 2013 at 10:40:50AM -0700, Gurucharan Shetty wrote: > On Thu, Aug 22, 2013 at 11:19 AM, Ben Pfaff <[email protected]> wrote: > > > Fixes the following sparse warnings introduced by commit 7c35397c84d > > (ofproto: Start ofport allocation from the previous max after restart.) > > > > ofproto.c:2106:58: warning: restricted ofp_port_t degrades to integer > > ofproto.c:2107:40: warning: restricted ofp_port_t degrades to integer > > ofproto.c:2107:40: warning: restricted ofp_port_t degrades to integer > > ofproto.c:2107:38: warning: incorrect type in assignment (different base > > types) > > ofproto.c:2107:38: expected restricted ofp_port_t [usertype] > > alloc_port_no > > ofproto.c:2107:38: got int > > > > This fix makes the code uglier. Maybe we should make 'alloc_port_no' > > and 'max_ports' "uint16_t"s instead of "ofp_port_t"s. > > > Sparse 0.4.3 did not show this warning to me (it comes in ubuntu 12.04). I > had to compile the sparse master branch for this to work for me. Sorry > about that.
No problem. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
