On Fri, Aug 23, 2013 at 1:33 PM, Ben Pfaff <[email protected]> wrote: > On Fri, Aug 23, 2013 at 12:46:47PM -0700, Jarno Rajahalme wrote: >> On Aug 23, 2013, at 11:26 AM, Ben Pfaff <[email protected]> wrote: >> > Looking at tnl_find() in ofproto/tunnel.c, it maintains the invariant >> > "set <field> to 0 if and only if we set <field>_flow to true", except >> > for <field> = ip_src. Is that a bug? >> > >> >> No, it is not a bug. Tunnel config allows you to leave local address >> unset (=0), allowing the selected route to determine the source >> address to use. Even more, it looks like find_route() in kernel >> might override the source address, even if it is given (in the >> config, or in the flow with _flow set to true). > > I see, thanks. > > The code might be more obviously correct like this. If anyone agrees > then I'll check it over and write it up formally.
The concept looks reasonable to me, although I didn't check the implementation for correctness. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
