On Fri, Aug 30, 2013 at 09:57:13AM -0700, gy...@nicira.com wrote:
> @@ -2981,7 +2986,8 @@ parse_l2_5_onward(const struct nlattr 
> *attrs[OVS_KEY_ATTR_MAX + 1],
>                      if (is_mask) {
>                          if (!is_all_zeros((const uint8_t *) nd_key,
>                                            sizeof *nd_key) &&
> -                            flow->tp_src != htons(0xffff)) {

I suspect that && here should be ||.  Is that correct?  If so, then
I'll update the patch and commit this:

> +                            (flow->tp_src != htons(0xffff) &&
> +                             flow->tp_dst != htons(0xffff))) {
>                              return ODP_FIT_ERROR;
>                          } else {
>                              expected_attrs |= UINT64_C(1) << OVS_KEY_ATTR_ND;
Thanks,

Ben.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to