On Sun, Sep 08, 2013 at 02:21:25AM +0300, Daniel Baluta wrote:
> This is a first step in implementing 'on demand flow counters'.
> We save flow_mod flags into newly created rule when a new flow
> is added, and echo them back in the flow stats request.
>
> Signed-off-by: Daniel Baluta <[email protected]>
It's a reasonable approach. Two comments:
* Some of the flags apply to the request, not to the flow.
Specifically, I don't think that it makes sense to save the
OFPUTIL_FF_CHECK_OVERLAP or OFPUTIL_FF_RESET_COUNTS flags with
the flow.
* If we save the flags this way, then we don't need the
send_flow_removed member anymore because it just reflects the
status of the OFPUTIL_FF_SEND_FLOW_REM flag.
Thanks,
Ben.
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
