On Wed, Sep 11, 2013 at 06:51:11PM -0700, Ethan Jackson wrote: > My only comment is that you might consider using thread safety > annotations to force users do un-reference actions they've taken a > reference of. That might be a pain though, not sure if it's worth it.
Thread-safety annotations make tons of sense for stuff that can screw up your program as seriously as a deadlock or a bad race. Ref-counts are more likely to either cause memory leaks (which though not good are often benign enough that they can remain for many release without noticing) or use-after-free errors (which are bad but valgrind finds them). We don't annotate for other related classes of memory errors. Maybe we should. I've thought about it before (previously with sparse). But I don't want to do it in this commit. Thanks a lot for the review. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
