Looks good to me, Only one question,
+ case 'a':
> + if (!fstat(fileno(file), &s) && !s.st_size) {
> + pcap_write_header(file);
> + }
> + break;
> +
> + default:
> + NOT_REACHED();
> }
>
Here, why do we check the (!st_size)? don't we allow append to empty file?
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
