On Tue, Oct 08, 2013 at 12:26:23PM +0300, Alexandru Copot wrote: > Signed-off-by: Alexandru Copot <[email protected]> > Cc: Daniel Baluta <[email protected]>
Thanks for the patch. ofp_print_role_status_message() duplicates the code for printing a role that is already found in ofp_print_role_message(). Please factor it out somehow. ofp_print_role_status_message() assert-fails if 'reason' is not valid, but I don't think the decode routine initializes (or checks) 'reason'. Thanks, Ben. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
