On Mon, Oct 14, 2013 at 03:20:43PM -0700, Ben Pfaff wrote: > On Fri, Oct 11, 2013 at 01:23:29PM +0900, Simon Horman wrote: > > Implementation note: > > > > All actions which modify a field are added to the action set > > at the point where "set" actions should be added. In general > > modifying a field many times is the same as only modifying it > > the last time so the implementation simply adds all set actions to > > the action set in the order they are specified. However, this breaks > > down if two actions modify different portions of the same field. > > > > Some examples. > > > > 1. load acting a subfield > > 2. mod_vlan_vid, mod_vlan_pcp > > > > If this is considered to be a problem one possible solution would be to > > either disallow all set actions other than set_field in write_actions. > > Another possible solution is prohibit problematic the actions listed above > > in write actions. > > > > Signed-off-by: Simon Horman <[email protected]> > > Thanks. > > I did a significant amount of simplification and editing on this. > I'll apply it to master in a minute. Here is the incremental followed > by the full commit.
Thanks a lot. I've looked over your changes and you do indeed seem to have simplified things quite nicely. I'll rebase and rework the remaining patches in the series accordingly and resubmit them for review. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
