Hi Ben,
On Tue, Oct 15, 2013 at 09:55:12AM -0700, Ben Pfaff wrote:
> I see that "make check-oftest" reports 8 failures and 1 error. (I
> haven't updated OFtest in ages, maybe newer versions would give
> different results.) I don't have time to chase these down this week,
> but it would be a much appreciated public service if anyone else wants
> to take a look.
>
> README-OFTest has instructions for running OFtest. I got these results
> with "make check-oftest OFTFLAGS='--verbose -T all'".
I have taken a look at the errors you list below in the following
environment.
OFtest: 926c30c ("netdev-dummy: Count rx packets regardless of source")
OVS: 48a5f33 ("OPENFLOW-1.1+: note on table-miss")
The revisions above were the head of the master branches
of the respective trees for each project earlier this afternoon.
I also applied the following patch to ovs as OFtest seems
to want to use a different (the new?) port.
--- begin ---
--- a/tests/run-oftest
+++ b/tests/run-oftest
@@ -74,7 +74,7 @@ for port in p1 p2 p3 p4; do
options:pstream=punix:$OVS_RUNDIR/$port
done
run ovs-vsctl \
- -- set-controller br0 tcp:127.0.0.1 \
+ -- set-controller br0 tcp:127.0.0.1:6653 \
-- set controller br0 connection-mode=out-of-band max-backoff=1000
# Run OFTest.
--- end ---
I have not yet investigated to see if there are any errors
that you didn't hit using -T all.
> ======================================================================
> ERROR: runTest (pktact.DirectPacketControllerQueue)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/blp/nicira/oftest/tests/pktact.py", line 349, in runTest
> self.handleFlow()
> File "/home/blp/nicira/oftest/tests/pktact.py", line 389, in handleFlow
> + str(self.portQueuesGet(queue_stats, egress_port)))
> File "/home/blp/nicira/oftest/tests/pktact.py", line 353, in portQueuesGet
> for qs in queue_stats.stats:
> AttributeError: queue_op_failed_error_msg instance has no attribute 'stats'
This tests passes in my environment.
>
> ======================================================================
> FAIL: runTest (port_stats.MultiFlowStats)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/blp/nicira/oftest/tests/port_stats.py", line 258, in runTest
> initTxInPort, initRxInPort + num_pkt1s + num_pkt2s)
> File "/home/blp/nicira/oftest/tests/port_stats.py", line 115, in verifyStats
> "Packet received does not match number sent")
> File "/home/blp/nicira/oftest/src/python/oftest/base_tests.py", line 88, in
> assertTrue
> unittest.TestCase.assertTrue(self, cond, msg)
> AssertionError: Packet received does not match number sent
I will send a patch for this shortly.
> ======================================================================
> FAIL: runTest (port_stats.SingleFlowStats)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/blp/nicira/oftest/tests/port_stats.py", line 179, in runTest
> verifyStats(self, ingress_port, test_timeout, initTxInPort, initRxInPort
> + num_sends)
> File "/home/blp/nicira/oftest/tests/port_stats.py", line 115, in verifyStats
> "Packet received does not match number sent")
> File "/home/blp/nicira/oftest/src/python/oftest/base_tests.py", line 88, in
> assertTrue
> unittest.TestCase.assertTrue(self, cond, msg)
> AssertionError: Packet received does not match number sent
Ditto (its the same patch)
> ======================================================================
> FAIL: runTest (flow_expire.FlowExpire)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/blp/nicira/oftest/tests/flow_expire.py", line 88, in runTest
> 'Flow table entry does not match')
> AssertionError: Flow table entry does not match
I see this but have not addressed it.
> ======================================================================
> FAIL: runTest (detailed_contr_sw_messages.DeleteEmerFlow)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/blp/nicira/oftest/tests/detailed_contr_sw_messages.py", line
> 468, in runTest
> 'Test Failed ')
> File "/home/blp/nicira/oftest/src/python/oftest/base_tests.py", line 88, in
> assertTrue
> unittest.TestCase.assertTrue(self, cond, msg)
> AssertionError: Test Failed
Ditto
> ======================================================================
> FAIL: runTest (flow_stats.SingleFlowStats)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/blp/nicira/oftest/tests/flow_stats.py", line 156, in runTest
> self.verifyStats(flow_mod_msg, match, ofp.OFPP_NONE, test_timeout, 0)
> File "/home/blp/nicira/oftest/tests/flow_stats.py", line 97, in verifyStats
> "Matches do not match")
> AssertionError: Matches do not match
Ditto
> ======================================================================
> FAIL: runTest (pktact.WildcardPriorityWithDelete)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/blp/nicira/oftest/tests/pktact.py", line 1150, in runTest
> self.verifyFlow(of_ports[0], of_ports[2])
> File "/home/blp/nicira/oftest/tests/pktact.py", line 1062, in verifyFlow
> receive_pkt_verify(self, egp, pkt, inp)
> File "/home/blp/nicira/oftest/src/python/oftest/testutils.py", line 309, in
> receive_pkt_verify
> "Did not receive packet port " + str(check_port))
> File "/home/blp/nicira/oftest/src/python/oftest/base_tests.py", line 88, in
> assertTrue
> unittest.TestCase.assertTrue(self, cond, msg)
> AssertionError: Did not receive packet port 3
I will send a patch (its the same patch again).
> ======================================================================
> FAIL: runTest (pktact.WildcardPriority)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/blp/nicira/oftest/tests/pktact.py", line 1119, in runTest
> self.verifyFlow(of_ports[0], of_ports[3])
> File "/home/blp/nicira/oftest/tests/pktact.py", line 1062, in verifyFlow
> receive_pkt_verify(self, egp, pkt, inp)
> File "/home/blp/nicira/oftest/src/python/oftest/testutils.py", line 309, in
> receive_pkt_verify
> "Did not receive packet port " + str(check_port))
> File "/home/blp/nicira/oftest/src/python/oftest/base_tests.py", line 88, in
> assertTrue
> unittest.TestCase.assertTrue(self, cond, msg)
> AssertionError: Did not receive packet port 4
Ditto
> ======================================================================
> FAIL: runTest (pktact.DirectLlcPackets)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/blp/nicira/oftest/tests/pktact.py", line 2530, in runTest
> IS_NOT_SNAP,
> File "/home/blp/nicira/oftest/tests/pktact.py", line 2510, in testPacket
> testPacketEthTypeNotEth(title, llc, is_snap)
> File "/home/blp/nicira/oftest/tests/pktact.py", line 2506, in
> testPacketEthTypeNotEth
> self.testPktsAgainstFlow(pkts, act, match)
> File "/home/blp/nicira/oftest/tests/pktact.py", line 1999, in
> testPktsAgainstFlow
> self.testPktAgainstFlow(title, pkt, acts, match, expected_result)
> File "/home/blp/nicira/oftest/tests/pktact.py", line 2071, in
> testPktAgainstFlow
> "Did not receive packet, expected a match")
> File "/home/blp/nicira/oftest/src/python/oftest/base_tests.py", line 88, in
> assertTrue
> unittest.TestCase.assertTrue(self, cond, msg)
> AssertionError: Did not receive packet, expected a match
I see a different error.
======================================================================
FAIL: pktact.DirectLlcPackets
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/horms/projects/openvswitch/oftest/tests/pktact.py", line 2550, in
runTest
IS_SNAP_NOT_IP,
File "/home/horms/projects/openvswitch/oftest/tests/pktact.py", line 2515, in
testPacket
testPacketEthTypeNotEth(title, llc, is_snap)
File "/home/horms/projects/openvswitch/oftest/tests/pktact.py", line 2511, in
testPacketEthTypeNotEth
self.testPktsAgainstFlow(pkts, act, match)
File "/home/horms/projects/openvswitch/oftest/tests/pktact.py", line 2001, in
testPktsAgainstFlow
self.testPktAgainstFlow(title, pkt, acts, match, expected_result)
File "/home/horms/projects/openvswitch/oftest/tests/pktact.py", line 2090, in
testPktAgainstFlow
self.assertTrue(rcv_pkt is None, "Received packet, expected drop")
File
"/home/horms/projects/openvswitch/oftest/src/python/oftest/base_tests.py", line
97, in assertTrue
unittest.TestCase.assertTrue(self, cond, msg)
AssertionError: Received packet, expected drop
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
