On Fri, Oct 18, 2013 at 5:22 PM, Pravin B Shelar <[email protected]> wrote: > diff --git a/datapath/flow.c b/datapath/flow.c > index faa4e15..73c4dbe 100644 > --- a/datapath/flow.c > +++ b/datapath/flow.c > +void ovs_flow_stats_get(struct sw_flow *flow, struct sw_flow_stats *res) > +{ [...] > + if (cpu == cur_cpu) > + local_bh_enable(); > + else > + spin_unlock(&stats->lock);
This unfortunately triggers some sparse warnings since it doesn't know how to check that the two if statement conditions are the same: CHECK /home/jgross/openvswitch/datapath/linux/flow.c /home/jgross/openvswitch/datapath/linux/flow.c:111:36: warning: context imbalance in 'ovs_flow_stats_get' - unexpected unlock /home/jgross/openvswitch/datapath/linux/flow.c:137:36: warning: context imbalance in 'ovs_flow_stats_clear' - unexpected unlock I don't know if there's a good way to quiet it down. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
