because our size of the multipart request buffer is effectively 0, always report multipart buffer overflow error for multipart requests with "more" flag set.
while this might be simpler if done in ofp-msgs.c, i put this in ofproto.c because it seems like a better place to implement the buffering logic if/when desirable. Signed-off-by: YAMAMOTO Takashi <yamam...@valinux.co.jp> --- ofproto/ofproto.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index b51b00f..515575e 100644 --- a/ofproto/ofproto.c +++ b/ofproto/ofproto.c @@ -5672,6 +5672,10 @@ handle_openflow__(struct ofconn *ofconn, const struct ofpbuf *msg) if (error) { return error; } + if (oh->version >= OFP13_VERSION && ofpmsg_is_stat(oh) && ofpmp_more(oh)) { + /* We have no buffer */ + return OFPERR_OFPBRC_MULTIPART_BUFFER_OVERFLOW; + } switch (type) { /* OpenFlow requests. */ -- 1.8.3.1 _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev