LGTM,

On Fri, Nov 1, 2013 at 2:08 PM, Ben Pfaff <b...@nicira.com> wrote:

> Nothing about the existing code in this function cares whether Goto-Table
> is the last action.
>
> Signed-off-by: Ben Pfaff <b...@nicira.com>
> ---
>  ofproto/ofproto-dpif-xlate.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
> index f19dbf1..f5bc12c 100644
> --- a/ofproto/ofproto-dpif-xlate.c
> +++ b/ofproto/ofproto-dpif-xlate.c
> @@ -2529,7 +2529,6 @@ do_xlate_actions(const struct ofpact *ofpacts,
> size_t ofpacts_len,
>              break;
>
>          case OFPACT_GOTO_TABLE: {
> -            /* It is assumed that goto-table is the last action. */
>              struct ofpact_goto_table *ogt = ofpact_get_GOTO_TABLE(a);
>
>              ovs_assert(ctx->table_id < ogt->table_id);
> --
> 1.7.10.4
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to