On 1 November 2013 13:31, Ben Pfaff <b...@nicira.com> wrote: > On Fri, Nov 01, 2013 at 01:06:39PM -0700, Joe Stringer wrote: > > When dealing with a large number of ports, one of the performance > > bottlenecks is that we loop through all netdevs in the main loop. Miimon > > is a contributor to this, executing even if it is not enabled on any > > devices. > > > > This patch introduces a counter for the number of netdevs with miimon > > configured. If this is 0, then we skip miimon_run() and miimon_wait(). > > In a test environment of 5000 internal ports and 50 tunnel ports with > > bfd, this reduces CPU usage from about 50% to about 45%. > > > > Signed-off-by: Joe Stringer <joestrin...@nicira.com> > > I think that netdev-linux should be responsible for dropping > miimon_cnt whenever a netdev_linux is destroyed. Probably > netdev_linux_destruct() is the right place. >
I agree, it looks much tidier there. I'll send an update for it.
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
