In flow_union_with_miniflow_range(), the variable 'msk' is curious. I
think that it could be both declared and initialized inside the "if
(start > 0) {" conditional statement.
The variables 'start' and 'end' seem to be treated oddly differently in
that function. 'start' is updated as we go, but 'end' is copied to a
new variable 'end_ofs' that is updated as we go (and 'end' is never
again used). I think that it would make sense to treat them the same
way, that is, to ditch 'end_ofs' and just use 'end'.
I have similar comments for the other new functions in flow.c.
The new functions are terribly similar. I wish I saw a nice way to
avoid duplicating code among them. Do you see any way?
_______________________________________________
dev mailing list
[email protected]
http://openvswitch.org/mailman/listinfo/dev
